1. add commonmark to project: npm install commonmark
2. require commonmark: commonmark = require('../node_modules/commonmark')
3. build: enyo pack
expected result: app loads normally
actual result: app fails to load with error:
SyntaxError: missing ; before statement
OS X 10.11.6, Firefox
Thanks, that looks like it should work!
I should be able to test it this week.
On Sep 12, 2016 9:43 AM, "Ryan Duffy (JIRA)" <firstname.lastname@example.org>
I copied the file BundleManifest.js directly over the old version in enyo-dev; is there a more elegant way to install a given git version using npm?
Having done that, I can directly require JSON files, for example
appinfo = require('../appinfo.json’),
It now works for modules that require a JSON file, e.g. entities, which requires xml.json:
entities = require('../node_modules/entities'),
But I haven’t yet got it working for a dependency of a dependency, e.g. commonmark, which requires entities.
commonmark = require('../node_modules/commonmark'),
LGTM. - Work for you?
Both PRs have been merged so calling this fixed.
- Thanks for the report and the additional fix. Let us know if you discover anything else!